-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to choose Qt style #21553
Allow to choose Qt style #21553
Conversation
glassez
commented
Oct 8, 2024
•
edited
Loading
edited
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
I think an upgrade to Qt 6.8 is needed before this can be merged. |
This comment was marked as duplicate.
This comment was marked as duplicate.
I don't see any reason for this yet... |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Everything is obvious to me. Qt 6.7.0 had some kind of bug that was fixed in one of the subsequent updates. Which one, it doesn't matter to me, because on Windows there is no problem just using Qt 6.7.3, which has it fixed. If you're interested, you could find out more precisely. If there are no more serious problems with this PR, I would prefer to end it. I don't want to spend too much time on this issue. |
I initially had such an idea, but then I rejected it. Windows 11 uses the windows11 theme by default, which recently provided with the release of Qt 6.7, and hardly anyone has had enough time to test the use of qBittorrent with this theme. In general, I would not recommend having such an option, at least if it just follows Qt default. We could have "default" option that enables qBittorrent own default option. |
What I was thinking is slightly different (keep in mind that this setting is Windows-only anyway):
|
That's what I care about. Wouldn't an option like "System" or "Default" look like something preferred/recommended? |
I think we can get around that by naming our default as What do you think? |
I think such options set would be confusing under current circumstances. Anyway, I don't want to pay too much of my attention to this topic. And I don't want it to slow down the release of version 5.0.1, which contains hotfixes of the most popular problems of v5.0.0. |
Or just be straightforward and say Fusion (dark mode) and System (default) because clearly, Fusion isn't giving many people the dark mode they want. The text label should say "Fusion is the only current Qt style compatible with Windows dark mode, for now". As long as we get users a way to get out of dark mode while being informative, this issue is over and done with. |
This is not true. "Windows11" style also supports it, AFAIK. |
So then we just need the Qt style dropdown to say:
Along with a text label that says "Dark mode on Windows only works with dark mode compatible Qt styles". Nothing else is necessary as long as we inform users of what each style can do. |
BTW, Windows style is also dark mode compatible, AFAIK. |
Re-read https://www.qt.io/blog/dark-mode-on-windows-11-with-qt-6.5 Styles below will follow the Windows system settings for dark "app" mode automatically as of Qt 6.5+
The problem currently for some users is that even though they have enabled dark "app" mode they don't want qBittorrent to respect that & want it to have a light pallette "Windows Vista style" aka the way it behaved in <=4.6.x until we changed to So, what we've enabled through Qt is an "auto" switch but some users want:
|
|
@Pentaphon Qt have been recommending to use
|
I don't want this backported to 5.0.1 as a potentially incomplete solution, because we are still discussing its options. I think our best option is a text label. A revised text could be "Hint: Fusion style is recommended. It has the better compatibility with Windows dark mode." @Pentaphon If I am interpreting correctly your commetns you essentially advocate in also changing the default style from Fusion to qt's, right? I am not entirely convinced that this is a good solution. |
This should go to 5.0.1 because a lot of people want to get out of using the dark mode that the Fusion theme enables. If you don't push this to 5.0.1, many people will keep complaining.
Yes but I would say: "Hint: Fusion style is recommended for best compatibility with Windows dark mode." That's all that needs to be said.
It does not matter what we use as default. We can use Fusion or any other Qt style by default as long as we have:
This should not be hard to figure out. There are more important bugs to fix as @glassez points out. |
If all styles except single one support dark mode, then it looks wasteful to tag them all. It's enough to mention in your text label that WindowsVista doesn't support dark mode, and that's it. |
IIRC, when high contrast is enabled Windows style is just forced. |
👎 IMO, all these explanations in the combobox itself can only make it more confusing, as well as the I expressed my opinion. And then do as you like. |
IMO, what is already in place is enough. |
Relevant prior PR qbittorrent#21553
Please see/continue in #21605 |
Relevant prior PR qbittorrent#21553
Relevant prior PR qbittorrent#21553
Yes, if that is the case then that is perfect. |
Relevant prior PR qbittorrent#21553
Relevant prior PR qbittorrent#21553
Relevant prior PR qbittorrent#21553
Relevant prior PR qbittorrent#21553
Relevant prior PR qbittorrent#21553